Fix ink label URL construction for .zarr segments#807
Open
pallman14 wants to merge 1 commit intoScrollPrize:mainfrom
Open
Fix ink label URL construction for .zarr segments#807pallman14 wants to merge 1 commit intoScrollPrize:mainfrom
pallman14 wants to merge 1 commit intoScrollPrize:mainfrom
Conversation
The download_inklabel() method was constructing incorrect URLs for ink label PNG files when the segment URL ended with .zarr extension. Before: .../20230827161847.zarr_inklabels.png (404 Not Found) After: .../20230827161847_inklabels.png (200 OK) The fix strips the .zarr extension from the segment ID before constructing the ink label filename. This fixes Tutorial 5 (Ink Detection) which was reported broken in Discord #newbie-questions.
|
@pallman14 is attempting to deploy a commit to the scroll Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.zarrURLsdownload_inklabel()method was including.zarrin the filenameProblem
When segment URLs end with
.zarr/, the code was constructing:Instead of:
Fix
Strip the
.zarrextension fromsegment_id_strbefore constructing the ink label filename (2 lines added).Testing
Impact
This fixes Tutorial 5 (Ink Detection) which was reported broken in Discord #newbie-questions.